Lint benchmarks in CI - #697
Merged
Merged
Conversation
The Makefile's dev-flake8, dev-pylint and dev-mypy cover benchmarks, but the Docker lint stages did not, so that tree was checked only on a laptop and only by whoever remembered to run make dev-lint. It had been failing on main since #690 as a result. The two findings it had accumulated go with it. The split gets maxsplit=1, which changes nothing. The empty-list comparison stays as it is, with a disable and a reason: `not ...` would accept None and the empty string equally, and the empty list is what the function contracts to return. flake8 and mypy were already clean over benchmarks, so this only widens what they cover.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Makefile's dev-flake8, dev-pylint and dev-mypy cover benchmarks, but the Docker lint stages did not, so that tree was checked only on a laptop and only by whoever remembered to run make dev-lint. It had been failing on main since #690 as a result.
The two findings it had accumulated go with it. The split gets maxsplit=1, which changes nothing. The empty-list comparison stays as it is, with a disable and a reason:
not ...would accept None and the empty string equally, and the empty list is what the function contracts to return.flake8 and mypy were already clean over benchmarks, so this only widens what they cover.